chore: set up manual CodeQL config for the repo, for nightly only#8110
chore: set up manual CodeQL config for the repo, for nightly only#8110
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
I'm not fully convinced that this will shift away from PR checks entirely, but there's probably only one way to try it. |
| - language: javascript-typescript | ||
| build-mode: none | ||
| - language: python | ||
| build-mode: none |
There was a problem hiding this comment.
Do we need python code analysis? I think we did have it before . . . but why? Just for owlbot.py?
AFAIK, the owlbot.py will be removed eventually as a part of the librarian migration. I suspect we can do without this?
There was a problem hiding this comment.
Yeah, mostly for owlbot.py. I'm afraid those are going to be with us for a little while still, and since the previous config covered them (and they actually do things during build that could cause problems), we should probably keep covering them.
On the plus side, those checks take very little time or effort. TS-JS is the big one.
|
Looking at the CI run for this PR, it still looks like the javascript-typescript analyzer check ran for a long time: "Successful in 299m" Note, by inspecting the run, we can see that it was in fact running based on your new workflow file: As a result, I don't think a merge is required to verify your improvments. |
pearigee
left a comment
pearigee
left a comment
There was a problem hiding this comment.
Can we verify the runtime improvements before merging?
I messed up my branches, sorry. I'll bug you again when it's finished CI. |
3 participants
CodeQL takes too long to run on the whole repo for every CI action. The existing CodeQL config is removed in favour of a new manual one, which this PR adds.
Fixes b/499026637 🦕